mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Dive site: remove [start|stop]FilterDiveSite signals

Browse source 
This is another case of a weird pattern where an object would
connect it's own signal to the slot of a different object.
There seems to be no reason why the former couldn't simply
call the latter.

Remove the [start|stop]FilterDiveSite signals of LocationInformationWidget
and call the corresponding functions of MultiFilterSortModel directly.
While doing so, replace the UUID argument by a pointer-to-divesite.
It will be converted anyway right at the beginning of the function.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-10-26 16:57:08 +02:00 • committed by Dirk Hohndel
parent f41bb32428
commit acd44467c1
4 changed files with 5 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qt-models/filtermodels.cpp
View file

@ -684,9 +684,9 @@ void MultiFilterSortModel::clearFilter()
myInvalidate();
}
void MultiFilterSortModel::startFilterDiveSite(uint32_t uuid)
void MultiFilterSortModel::startFilterDiveSite(struct dive_site *ds)
{
curr_dive_site = get_dive_site_by_uuid(uuid);
curr_dive_site = ds;
myInvalidate();
}