From ada32f999eb68beb5d0c5c309fcf6190e0a64c5e Mon Sep 17 00:00:00 2001 From: Michael Keller Date: Tue, 31 Jan 2023 11:14:37 +1300 Subject: [PATCH] Cleanup: Remove 'data' field from 'DeviceDetails'. `device_data_t data` in DeviceDetails has never been populated since it was first added, and consequently is not used. This is confusing, especially as certain fields inside `device_data_t` have been added directly to `DeviceDetails` in the meantime (e.g. `firmwareVersion`). Separated from #3568 as per https://github.com/subsurface/subsurface/pull/3568#pullrequestreview-1274995287. Signed-off-by: Michael Keller --- core/devicedetails.cpp | 1 - core/devicedetails.h | 1 - 2 files changed, 2 deletions(-) diff --git a/core/devicedetails.cpp b/core/devicedetails.cpp index 18941a0e2..1fe1fed00 100644 --- a/core/devicedetails.cpp +++ b/core/devicedetails.cpp @@ -13,7 +13,6 @@ setpoint::setpoint(unsigned char sp, unsigned char depth) : DeviceDetails::DeviceDetails(QObject *parent) : QObject(parent), - data(0), syncTime(false), setPointFallback(0), ccrMode(0), diff --git a/core/devicedetails.h b/core/devicedetails.h index cb1a5ad1e..b8dbfd490 100644 --- a/core/devicedetails.h +++ b/core/devicedetails.h @@ -26,7 +26,6 @@ class DeviceDetails : public QObject public: explicit DeviceDetails(QObject *parent = 0); - device_data_t *data; QString serialNo; QString firmwareVersion; QString customText;