mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-31 19:53:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

libdivecomputer does crazy gas mixes too

Browse source 
Did I just say "In comparison, the libdivecomputer output is nice and
sane"?

It turns out that libdivecomputer has been doing some drugs too when it
comes to gas mixes.  Like showing O2 percentages as 255.0% and N2
percentages as -155.0%.

Clearly libdivecomputer uses a 'unsigned char' for oxygen percentage,
and makes "-1" be "undefined".  And then it prints that non-existing mix
out, and in the process does MATH on the damn thing ("100-O2") to
"calculate" the nitrogen percentage.

Christ.

Just make the parser silently ignore the craziness, because printing out
"Strange percentage reading -155.0" a few hundred times just doesn't
make anything any better.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Linus Torvalds 2011-09-01 13:46:24 -07:00
parent 9741913124
commit adc7280c02
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
parse-xml.c
View file

@ -326,6 +326,9 @@ static void percent(char *buffer, void *_fraction)
static void gasmix(char *buffer, void *_fraction) static void gasmix(char *buffer, void *_fraction)
{ {
/* libdivecomputer does negative percentages. */
if (*buffer == '-')
return;
if (gasmix_index < MAX_MIXES) if (gasmix_index < MAX_MIXES)
percent(buffer, _fraction); percent(buffer, _fraction);
} }