mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

When no dive is displayed, the DiveNotes field should not be editable

Browse source 
This also fixes a potential crash if no dives were loaded and the user
started editing the fields and clicked OK.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2013-05-19 17:38:20 -07:00
parent f67d3d4bbc
commit adc7654816
1 changed files with 32 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
qt-ui/maintab.cpp
View file

@ -28,12 +28,14 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
ui->diveNotesMessage->hide(); ui->diveNotesMessage->hide();
ui->diveNotesMessage->setCloseButtonVisible(false); ui->diveNotesMessage->setCloseButtonVisible(false);
ui->location->setReadOnly(false); // we start out with the fields read-only; once things are
ui->divemaster->setReadOnly(false); // filled from a dive, they are made writeable
ui->buddy->setReadOnly(false); ui->location->setReadOnly(true);
ui->suit->setReadOnly(false); ui->divemaster->setReadOnly(true);
ui->notes->setReadOnly(false); ui->buddy->setReadOnly(true);
ui->rating->setReadOnly(false); ui->suit->setReadOnly(true);
ui->notes->setReadOnly(true);
ui->rating->setReadOnly(true);
ui->editAccept->hide(); ui->editAccept->hide();
ui->editReset->hide(); ui->editReset->hide();
@ -62,9 +64,9 @@ MainTab::MainTab(QWidget *parent) : QTabWidget(parent),
bool MainTab::eventFilter(QObject* object, QEvent* event) bool MainTab::eventFilter(QObject* object, QEvent* event)
{ {
if (event->type() == QEvent::FocusIn) { if (event->type() == QEvent::FocusIn) {
if (ui->editAccept->isVisible()) { if (ui->editAccept->isVisible() || !currentDive)
return false; return false;
}
ui->editAccept->setChecked(true); ui->editAccept->setChecked(true);
ui->editAccept->show(); ui->editAccept->show();
ui->editReset->show(); ui->editReset->show();
@ -92,6 +94,12 @@ void MainTab::clearInfo()
ui->waterTemperatureText->clear(); ui->waterTemperatureText->clear();
ui->airTemperatureText->clear(); ui->airTemperatureText->clear();
ui->airPressureText->clear(); ui->airPressureText->clear();
ui->location->setReadOnly(true);
ui->divemaster->setReadOnly(true);
ui->buddy->setReadOnly(true);
ui->suit->setReadOnly(true);
ui->notes->setReadOnly(true);
ui->rating->setReadOnly(true);
} }
void MainTab::clearStats() void MainTab::clearStats()
@ -143,6 +151,14 @@ void MainTab::updateDiveInfo(int dive)
UPDATE_TEXT(d, buddy); UPDATE_TEXT(d, buddy);
/* infoTab */ /* infoTab */
if (d) { if (d) {
/* make the fields writeable */
ui->location->setReadOnly(false);
ui->divemaster->setReadOnly(false);
ui->buddy->setReadOnly(false);
ui->suit->setReadOnly(false);
ui->notes->setReadOnly(false);
ui->rating->setReadOnly(false);
/* and fill them from the dive */
ui->rating->setCurrentStars(d->rating); ui->rating->setCurrentStars(d->rating);
ui->maximumDepthText->setText(get_depth_string(d->maxdepth, TRUE)); ui->maximumDepthText->setText(get_depth_string(d->maxdepth, TRUE));
ui->averageDepthText->setText(get_depth_string(d->meandepth, TRUE)); ui->averageDepthText->setText(get_depth_string(d->meandepth, TRUE));
@ -165,6 +181,14 @@ void MainTab::updateDiveInfo(int dive)
else else
ui->airPressureText->clear(); ui->airPressureText->clear();
} else { } else {
/* make the fields read-only */
ui->location->setReadOnly(true);
ui->divemaster->setReadOnly(true);
ui->buddy->setReadOnly(true);
ui->suit->setReadOnly(true);
ui->notes->setReadOnly(true);
ui->rating->setReadOnly(true);
/* clear the fields */
ui->rating->setCurrentStars(0); ui->rating->setCurrentStars(0);
ui->sacText->clear(); ui->sacText->clear();
ui->otuText->clear(); ui->otuText->clear();