mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: use helper to avoid NULL dereference

Browse source 
We have these helper functions for exactly this purpose.

Found by Coverity. Fixes CID 350129

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2019-10-27 15:54:33 -04:00
parent 81ea47a498
commit b0a00cd15d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/xmp_parser.cpp
View file

@ -61,7 +61,7 @@ static timestamp_t extract_timestamp_from_attributes(const xmlNode *node)
const xmlChar *ns = p->ns ? p->ns->prefix : nullptr; const xmlChar *ns = p->ns ? p->ns->prefix : nullptr;
// Check for xmp::CreateDate property // Check for xmp::CreateDate property
if (!strcmp((const char *)ns, "xmp") && !strcmp((const char *)p->name, "CreateDate")) { if (same_string((const char *)ns, "xmp") && same_string((const char *)p->name, "CreateDate")) {
// We only support a single property value // We only support a single property value
if (!p->children || !p->children->content) if (!p->children || !p->children->content)
return 0; return 0;