mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: fold DiveComputerManagementDialog::update() into init()

Browse source 
update() was only called in conjunction with init(). No point in
having two functions. The separation between both functions seemed
arbitrary anyway.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-06-15 23:51:28 +02:00 • committed by Dirk Hohndel
parent f54764cdbc
commit b0cc416954
3 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
desktop-widgets/divecomputermanagementdialog.cpp
View file

@ -20,7 +20,11 @@ DiveComputerManagementDialog::DiveComputerManagementDialog(QWidget *parent, Qt::
void DiveComputerManagementDialog::init() void DiveComputerManagementDialog::init()
{ {
model.reset(new DiveComputerModel(dcList.dcMap)); model.reset(new DiveComputerModel(dcList.dcMap));
model->update();
ui.tableView->setModel(model.data()); ui.tableView->setModel(model.data());
ui.tableView->resizeColumnsToContents();
ui.tableView->setColumnWidth(DiveComputerModel::REMOVE, 22);
layout()->activate();
} }
DiveComputerManagementDialog *DiveComputerManagementDialog::instance() DiveComputerManagementDialog *DiveComputerManagementDialog::instance()
@ -29,14 +33,6 @@ DiveComputerManagementDialog *DiveComputerManagementDialog::instance()
return self; return self;
} }
void DiveComputerManagementDialog::update()
{
model->update();
ui.tableView->resizeColumnsToContents();
ui.tableView->setColumnWidth(DiveComputerModel::REMOVE, 22);
layout()->activate();
}
void DiveComputerManagementDialog::tryRemove(const QModelIndex &index) void DiveComputerManagementDialog::tryRemove(const QModelIndex &index)
{ {
if (index.column() != DiveComputerModel::REMOVE) if (index.column() != DiveComputerModel::REMOVE)

1
desktop-widgets/divecomputermanagementdialog.h
View file

@ -12,7 +12,6 @@ class DiveComputerManagementDialog : public QDialog {
public: public:
static DiveComputerManagementDialog *instance(); static DiveComputerManagementDialog *instance();
void update();
void init(); void init();
public public

1
desktop-widgets/mainwindow.cpp
View file

@ -892,7 +892,6 @@ void MainWindow::on_actionDivelogs_de_triggered()
void MainWindow::on_actionEditDeviceNames_triggered() void MainWindow::on_actionEditDeviceNames_triggered()
{ {
DiveComputerManagementDialog::instance()->init(); DiveComputerManagementDialog::instance()->init();
DiveComputerManagementDialog::instance()->update();
DiveComputerManagementDialog::instance()->show(); DiveComputerManagementDialog::instance()->show();
} }