mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

mobile/models: correctly reset the connection model

Browse source 
Qt hates empty ranges, and even for a non-empty range, this is better
implemented as a reset than a remove.

This fixes a crash that I have been able to create on iOS by rescanning
for devices on the download page.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2020-04-10 14:31:34 -07:00
parent 1fd8ea9d49
commit b241d09694
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
core/connectionlistmodel.cpp
View file

@ -39,9 +39,12 @@ void ConnectionListModel::addAddress(const QString &address)
void ConnectionListModel::removeAllAddresses() void ConnectionListModel::removeAllAddresses()
{ {
beginRemoveRows(QModelIndex(), 0, rowCount()); if (rowCount() == 0)
return;
beginResetModel();
m_addresses.clear(); m_addresses.clear();
endRemoveRows(); endResetModel();
} }
int ConnectionListModel::indexOf(const QString &address) const int ConnectionListModel::indexOf(const QString &address) const