mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-01 05:53:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Don't leak the buffer or temporary file used to save the dive

Browse source 
Signed-off-by: Thiago Macieira <thiago@macieira.org>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Thiago Macieira 2013-12-11 17:56:31 -08:00 • committed by Dirk Hohndel
parent 04ec3cf31f
commit b3d59cb890
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
qt-ui/subsurfacewebservices.cpp
View file

@ -155,6 +155,8 @@ static char *prepare_dives_for_divelogs(const bool selected)
membuf = (char *)malloc(streamsize + 1); membuf = (char *)malloc(streamsize + 1);
if (!membuf || !fread(membuf, streamsize, 1, f)) { if (!membuf || !fread(membuf, streamsize, 1, f)) {
qDebug() << errPrefix << "memory error"; qDebug() << errPrefix << "memory error";
fclose(f);
free((void *)membuf);
free((void *)tempfile); free((void *)tempfile);
return NULL; return NULL;
} }
@ -168,6 +170,7 @@ static char *prepare_dives_for_divelogs(const bool selected)
doc = xmlReadMemory(membuf, strlen(membuf), "divelog", NULL, 0); doc = xmlReadMemory(membuf, strlen(membuf), "divelog", NULL, 0);
if (!doc) { if (!doc) {
qDebug() << errPrefix << "xml error"; qDebug() << errPrefix << "xml error";
free((void *)membuf);
free((void *)tempfile); free((void *)tempfile);
return NULL; return NULL;
} }