mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Statistics: un-globalize stats_selection

Browse source 
The statistics of the selected dives were calculated
a) into a global objects and
b) at a completely different place than where they're used.

There's no plausible reason for either. There fore render
into a caller-provided structure at the place of use.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-10-06 16:30:57 +02:00 • committed by Dirk Hohndel
parent 97991e2b9f
commit b61f6f66d8
4 changed files with 9 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

5
core/statistics.h
View file

@ -37,7 +37,6 @@ typedef struct
bool is_trip;
char *location;
} stats_t;
extern stats_t stats_selection;
struct stats_summary {
stats_t *stats_yearly;
@ -54,9 +53,9 @@ extern char *get_minutes(int seconds);
extern void init_stats_summary(struct stats_summary *stats);
extern void free_stats_summary(struct stats_summary *stats);
extern void calculate_stats_summary(struct stats_summary *stats);
extern void calculate_stats_selected(stats_t *stats_selection);
extern void get_gas_used(struct dive *dive, volume_t gases[MAX_CYLINDERS]);
extern void process_selected_dives(void);
void selected_dives_gas_parts(volume_t *o2_tot, volume_t *he_tot);
extern void selected_dives_gas_parts(volume_t *o2_tot, volume_t *he_tot);
#ifdef __cplusplus
}