From b6d830f0047cf0f68d9f7564f02c6b527f5051a0 Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Fri, 3 May 2019 22:49:39 +0200 Subject: [PATCH] Map: remove dead code When entering map-edit mode and the dive site existed, its coordinates were extracted but never used. Remove that useless if-branch. Signed-off-by: Berthold Stoeger --- map-widget/qmlmapwidgethelper.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/map-widget/qmlmapwidgethelper.cpp b/map-widget/qmlmapwidgethelper.cpp index e4c62ccd0..1e8199adf 100644 --- a/map-widget/qmlmapwidgethelper.cpp +++ b/map-widget/qmlmapwidgethelper.cpp @@ -241,16 +241,13 @@ void MapWidgetHelper::enterEditMode(struct dive_site *ds) return; m_editMode = true; - MapLocation *exists = m_mapLocationModel->getMapLocation(ds); - QGeoCoordinate coord; // if divesite doesn't exist in the model, add a new MapLocation. + MapLocation *exists = m_mapLocationModel->getMapLocation(ds); if (!exists) { // If the dive site doesn't have a GPS location, use the centre of the map - coord = has_location(&ds->location) ? getCoordinates(ds) - : m_map->property("center").value(); + QGeoCoordinate coord = has_location(&ds->location) ? getCoordinates(ds) + : m_map->property("center").value(); m_mapLocationModel->add(new MapLocation(ds, coord, QString(ds->name))); - } else { - coord = exists->coordinate(); } centerOnDiveSite(ds); emit editModeChanged();