mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-01 01:43:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Print: improve new page detection in table print

Browse source 
There is a potential issue when placing a heading on a new
page. If the height of a data row is larger of that of
a heading, a new heading can end up at the bottom of a page
leaving that page with two headings.

To solve that we add line breaks (<br>) until the new
page is reached and add the heading there. Algorithm
assumes that the height of a heading is larger than
a line break. Also it is now obviously even slower.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
This commit is contained in:
Lubomir I. Ivanov 2013-07-12 14:08:25 +03:00 • committed by Dirk Hohndel
parent 2bfda14c0b
commit b722bf6931
1 changed files with 23 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
qt-ui/printlayout.cpp
View file

@ -119,9 +119,11 @@ void PrintLayout::printTable() const
"</style>"
);
// setDefaultStyleSheet() doesn't work here?
const QString heading(insertTableHeadingRow());
const QString lineBreak("<br>");
QString htmlText = styleSheet + "<table cellspacing='0' width='100%'>";
QString htmlTextPrev;
int pageCountNew = 1, pageCount;
int pageCountNew = 1, pageCount = 0, lastPageWithHeading = 0;
bool insertHeading = true;
int i;
@ -130,16 +132,33 @@ void PrintLayout::printTable() const
if (!dive->selected && printOptions->print_selected)
continue;
if (insertHeading) {
htmlText += insertTableHeadingRow();
htmlTextPrev = htmlText;
htmlText += heading;
doc.setHtml(htmlText);
pageCount = doc.pageCount();
// prevent adding two headings on the same page
if (pageCount == lastPageWithHeading) {
htmlText = htmlTextPrev;
// add line breaks until a new page is reached
while (pageCount == lastPageWithHeading) {
htmlTextPrev = htmlText;
htmlText += lineBreak;
doc.setHtml(htmlText);
pageCount = doc.pageCount();
}
// revert last line break from the new page and add heading
htmlText = htmlTextPrev;
htmlText += heading;
}
insertHeading = false;
lastPageWithHeading = pageCount;
}
htmlTextPrev = htmlText;
htmlText += insertTableDataRow(dive);
doc.setHtml(htmlText);
pageCount = pageCountNew;
pageCountNew = doc.pageCount();
/* if the page count increases after adding this row we 'revert'
* and add a heading instead. */
// if the page count increases revert and add heading instead
if (pageCountNew > pageCount) {
htmlText = htmlTextPrev;
insertHeading = true;