mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-07 19:53:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

BLE support: simplify write function

Browse source 
It seems clearer to bail when list is empty...

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2017-09-20 19:19:25 -04:00
parent 16d9b0c790
commit bb1df1218d
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
core/qt-ble.cpp
View file

@ -151,24 +151,24 @@ dc_status_t BLEObject::write(const void *data, size_t size, size_t *actual)
} }
QList<QLowEnergyCharacteristic> list = preferredService()->characteristics(); QList<QLowEnergyCharacteristic> list = preferredService()->characteristics();
if (list.isEmpty())
return DC_STATUS_IO;
QByteArray bytes((const char *)data, (int) size); QByteArray bytes((const char *)data, (int) size);
if (!list.isEmpty()) { const QLowEnergyCharacteristic &c = list.constFirst();
const QLowEnergyCharacteristic &c = list.constFirst(); QLowEnergyService::WriteMode mode;
QLowEnergyService::WriteMode mode;
mode = (c.properties() & QLowEnergyCharacteristic::WriteNoResponse) ? mode = (c.properties() & QLowEnergyCharacteristic::WriteNoResponse) ?
QLowEnergyService::WriteWithoutResponse : QLowEnergyService::WriteWithoutResponse :
QLowEnergyService::WriteWithResponse; QLowEnergyService::WriteWithResponse;
if (IS_SHEARWATER(device)) if (IS_SHEARWATER(device))
bytes.prepend("\1\0", 2); bytes.prepend("\1\0", 2);
preferredService()->writeCharacteristic(c, bytes, mode); preferredService()->writeCharacteristic(c, bytes, mode);
return DC_STATUS_SUCCESS; return DC_STATUS_SUCCESS;
}
return DC_STATUS_IO;
} }
dc_status_t BLEObject::read(void *data, size_t size, size_t *actual) dc_status_t BLEObject::read(void *data, size_t size, size_t *actual)