cleanup: remove getDivesInTrip() in qthelper.cpp

This function was not used anywhere. Moreover, remove a few
unused includes from qthelper.h. Surprisingly, a number of users
of qthelper.h depend on these, so readd them at the appropriate
places.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

core/metadata.cpp

@@ -5,6 +5,7 @@
 #include "qthelper.h"
 #include <QString>
 #include <QFile>
+#include <QFileInfo>
 #include <QDateTime>
 
 // Weirdly, android builds fail owing to undefined UINT64_MAX

core/qt-init.cpp

@@ -4,6 +4,7 @@
 #include <QNetworkProxy>
 #include <QLibraryInfo>
 #include <QTextCodec>
+#include <QTranslator>
 #include "qthelper.h"
 #include "errorhelper.h"
 #include "core/settings/qPref.h"

core/qthelper.cpp

@@ -290,19 +290,6 @@ bool gpsHasChanged(struct dive *dive, struct dive *master, const QString &gps_te
 }
 #endif
 
-QList<int> getDivesInTrip(dive_trip_t *trip)
-{
-	QList<int> ret;
-	int i;
-	struct dive *d;
-	for_each_dive (i, d) {
-		if (d->divetrip == trip) {
-			ret.push_back(get_divenr(d));
-		}
-	}
-	return ret;
-}
-
 static xmlDocPtr get_stylesheet_doc(const xmlChar *uri, xmlDictPtr, int, void *, xsltLoadType)
 {
 	QFile f(QLatin1String(":/xslt/") + (const char *)uri);

core/qthelper.h

@@ -19,15 +19,12 @@ enum watertypes {FRESHWATER, BRACKISHWATER, EN13319WATER, SALTWATER, DC_WATERTYP
 
 #ifdef __cplusplus
 
-#include <QMultiMap>
 #include <QString>
-#include <QTranslator>
-#include <QDir>
 #include "core/gettextfromc.h"
+
 QString weight_string(int weight_in_grams);
 QString distance_string(int distanceInMeters);
 bool gpsHasChanged(struct dive *dive, struct dive *master, const QString &gps_text, bool *parsed_out = 0);
-QList<int> getDivesInTrip(struct dive_trip *trip);
 QString get_gas_string(struct gasmix gas);
 QString get_taglist_string(struct tag_entry *tag_list);
 QStringList stringToList(const QString &s);

desktop-widgets/preferences/preferences_language.cpp

@@ -4,7 +4,7 @@
 #include "core/qthelper.h"
 #include "core/settings/qPrefLanguage.h"
 
-#include <QApplication>
+#include <QDir>
 #include <QMessageBox>
 #include <QSortFilterProxyModel>
 

desktop-widgets/templatelayout.cpp

@@ -1,4 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
+#include <QDir>
+#include <QFile>
 #include <QFileDevice>
 #include <QRegularExpression>
 #include <QTextStream>

qt-models/models.cpp

@@ -10,6 +10,7 @@
 #include "core/dive.h"
 #include "core/gettextfromc.h"
 
+#include <QDir>
 #include <QLocale>
 
 Qt::ItemFlags GasSelectionModel::flags(const QModelIndex&) const