mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-12-01 06:30:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

QML UI: avoid clearing and rebuilding the dive list model

Browse source 
This causes all profiles to be rendered which is a massive performance
concern.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2016-01-27 12:11:37 -08:00
parent e895374e4b
commit bda0b01216
1 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
qt-mobile/qmlmanager.cpp
View file

@ -344,7 +344,7 @@ QString QMLManager::commitChanges(QString diveId, QString date, QString location
bool needResort = false;
if (date != get_dive_date_string(d->when)) {
needResort = true;
diveChanged = needResort = true;
QDateTime newDate;
// what a pain - Qt will not parse dates if the day of the week is incorrect
// so if the user changed the date but didn't update the day of the week (most likely behavior, actually),
@ -479,10 +479,23 @@ QString QMLManager::commitChanges(QString diveId, QString date, QString location
free(d->notes);
d->notes = strdup(qPrintable(notes));
}
if (needResort)
int oldIdx = get_idx_by_uniq_id(d->id);
if (needResort) {
// we know that the only thing that might happen in a resort is that
// this one dive moves to a different spot in the dive list
sort_table(&dive_table);
int newIdx = get_idx_by_uniq_id(d->id);
if (newIdx != oldIdx) {
DiveObjectHelper *newDive = new DiveObjectHelper(d);
DiveListModel::instance()->removeDive(oldIdx);
DiveListModel::instance()->insertDive(newIdx, newDive);
diveChanged = false; // because we already modified things
}
}
if (diveChanged)
DiveListModel::instance()->updateDive(oldIdx, d);
if (diveChanged || needResort) {
refreshDiveList();
mark_divelist_changed(true);
// this is called "commit" for a reason - when the user saves an
// edit they have a reasonable expectation that their data is actually