mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

core: enable compiler warngings for report_error and report_info

Browse source 
printf() is a horrible interface as it does no type checking.
Let's at least use the compiler to check format strings and
arguments. This obviously doesn't work for translated strings
and using report_error on translated strings is dubious. But OK.

Had to convert a number of report_error() calls to supress
warnings.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-03-12 09:17:50 +01:00 • committed by Dirk Hohndel
parent fcf0bda042
commit bfbf4934dd
13 changed files with 39 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

4
core/uploadDiveShare.cpp
View file

@ -100,7 +100,7 @@ void uploadDiveShare::uploadTimeoutSlot()
reply = NULL;
}
QString err(tr("dive-share.com not responding"));
report_error(err.toUtf8());
report_error("%s", qPrintable(err));
emit uploadFinish(false, err, QByteArray());
}
@ -113,6 +113,6 @@ void uploadDiveShare::uploadErrorSlot(QNetworkReply::NetworkError error)
reply = NULL;
}
QString err(tr("network error %1").arg(error));
report_error(err.toUtf8());
report_error("%s", qPrintable(err));
emit uploadFinish(false, err, QByteArray());
}