mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 05:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Desktop: use undo command when replanning dive

Browse source 
Instead of copying the displayed dive, generate an undo command.
This makes the replanning an undoable action and fixes a bug
where the dive details have not been updated correctly.

Fixes #2280

Reported-by: Stefan Fuchs <sfuchs@gmx.de>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-10-06 21:01:21 +02:00 committed by Dirk Hohndel
parent 7b730602c6
commit c479c5ca36
2 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
CHANGELOG.md
View file

@ -1,4 +1,7 @@
Mobile: add support for editing the dive number of a dive
Desktop: make dive replanning undoable
Desktop: update statistics tab on undo or redo
Planner: update dive details when replanning dive [#2280]
Export: when exporting dive sites in dive site mode, export selected dive sites [#2275]
Mobile: fix several bugs in the handling of incorrect or unverified cloud credentials
Mobile: try to adjust the UI for cases with large default font relative to screen size

4
qt-models/diveplannermodel.cpp
View file

@ -6,7 +6,6 @@
#include "qt-models/models.h"
#include "core/device.h"
#include "core/qthelper.h"
#include "core/divelist.h" // for mark_divelist_changed()
#include "core/settings/qPrefDivePlanner.h"
#include "desktop-widgets/command.h"
#include "core/gettextfromc.h"
@ -1176,8 +1175,7 @@ void DivePlannerPointsModel::createPlan(bool replanCopy)
Command::addDive(&displayed_dive, false, false);
} else {
// we were planning an old dive and rewrite the plan
mark_divelist_changed(true);
copy_dive(&displayed_dive, current_dive);
Command::replanDive(&displayed_dive);
}
// Remove and clean the diveplan, so we don't delete