mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
get rid of some foreach and Q_FOREACH constructs
See https://www.kdab.com/goodbye-q_foreach/ This is reduced to the places where the container is const or can be made const without the need to always introduce an extra variable. Sadly qAsConst (Qt 5.7) and std::as_const (C++17) are not available in all supported setups. Also do some minor cleanups along the way. Signed-off-by: Rolf Eike Beer <eike@sf-mail.de>
This commit is contained in:
parent
2b9ca488fd
commit
c4c8094e32
21 changed files with 62 additions and 49 deletions
|
@ -1144,7 +1144,7 @@ QStringList imageExtensionFilters()
|
|||
QStringList videoExtensionFilters()
|
||||
{
|
||||
QStringList filters;
|
||||
foreach (const QString &format, videoExtensionsList)
|
||||
for (const QString &format: videoExtensionsList)
|
||||
filters.append("*" + format);
|
||||
return filters;
|
||||
}
|
||||
|
@ -1506,9 +1506,9 @@ int parse_seabear_header(const char *filename, char **params, int pnr)
|
|||
|
||||
parseLine = f.readLine().trimmed();
|
||||
|
||||
QStringList currColumns = parseLine.split(';');
|
||||
const QStringList currColumns = parseLine.split(';');
|
||||
unsigned short index = 0;
|
||||
Q_FOREACH (QString columnText, currColumns) {
|
||||
for (const QString &columnText: currColumns) {
|
||||
if (columnText == "Time") {
|
||||
params[pnr++] = strdup("timeField");
|
||||
params[pnr++] = intdup(index++);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue