mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: remove default constructor from MapLocation

Browse source 
Since this is no longer a Q_METATYPE, nobody will try to
default construct this object. Remove the default constructor
and guarantee that there will be no null divesite.

Of course, the lack of default constructor means that the
default argument to the "selected" member variable should
be removed.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-09-01 00:26:51 +02:00 • committed by Dirk Hohndel
parent 0c374af176
commit c5f355ee8b
2 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
qt-models/maplocationmodel.cpp
View file

@ -12,10 +12,6 @@
#define MIN_DISTANCE_BETWEEN_DIVE_SITES_M 50.0
MapLocation::MapLocation() : divesite(nullptr), selected(false)
{
}
MapLocation::MapLocation(struct dive_site *dsIn, QGeoCoordinate coordIn, QString nameIn, bool selectedIn) :
divesite(dsIn), coordinate(coordIn), name(nameIn), selected(selectedIn)
{

3
qt-models/maplocationmodel.h
View file

@ -13,7 +13,6 @@
class MapLocation
{
public:
explicit MapLocation();
explicit MapLocation(struct dive_site *ds, QGeoCoordinate coord, QString name, bool selected);
QVariant getRole(int role) const;
@ -30,7 +29,7 @@ public:
struct dive_site *divesite;
QGeoCoordinate coordinate;
QString name;
bool selected = false;
bool selected;
};
class MapLocationModel : public QAbstractListModel