mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-31 21:53:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

Show all autocompletes after entry of comma in tag list

Browse source 
The almost 3 year old commit e1db5f21b1 introduced the behavior
that you need to type at least 1 character for a tag to show any
autocompleted data. While this went unnoticed for years, there
is always a user that notices this changed behavior.

The solution is rather simple. Do allow the 0 lenght string
to act as seed for autocompletion instead of just returning, and
doing no autocomplete at all.

As the afore mentioned commit was explicitly meant to prevent over
active firing of the tag list autocompleter, this (simple) change
is carefully tested on this, and no adverse effects are visible.

Fixes: #605 (wrt the 1 character issue)

Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
This commit is contained in:
Jan Mulder 2017-11-16 12:02:01 +01:00
parent 010f5f2abc
commit c8a7712ea5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
desktop-widgets/tagwidget.cpp
View file

@ -91,7 +91,7 @@ void TagWidget::reparse()
* Do not show the completer when not in edit mode - basically * Do not show the completer when not in edit mode - basically
* this returns when we are accepting or discarding the changes. * this returns when we are accepting or discarding the changes.
*/ */
if (MainWindow::instance()->information()->isEditing() == false || currentText.length() == 0) { if (MainWindow::instance()->information()->isEditing() == false) {
return; return;
} }