mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-31 20:43:24 +00:00
Code Issues Projects Releases Packages Wiki Activity

Clear memory allocated for event names

Browse source 
parse-xml.c:
When parsing events, we allocate memory for the event 'name' attribute,
but also have to free this memory eventually. Let's do that in event_end()
right after add_event() is called.

Fixes a long-running memory leak in the parser.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lubomir I. Ivanov 2012-12-24 03:51:39 +02:00 • committed by Dirk Hohndel
parent 720d4c65e8
commit cc3b87c044
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
parse-xml.c
View file

@ -1096,10 +1096,13 @@ static struct divecomputer *get_dc(void)
static void event_end(void) static void event_end(void)
{ {
struct divecomputer *dc = get_dc(); struct divecomputer *dc = get_dc();
if (cur_event.name && strcmp(cur_event.name, "surface") != 0) if (cur_event.name) {
add_event(dc, cur_event.time.seconds, if (strcmp(cur_event.name, "surface") != 0)
cur_event.type, cur_event.flags, add_event(dc, cur_event.time.seconds,
cur_event.value, cur_event.name); cur_event.type, cur_event.flags,
cur_event.value, cur_event.name);
free((void *)cur_event.name);
}
cur_event.active = 0; cur_event.active = 0;
} }