preferences: use std::string in struct preferences

This is a messy commit, because the "qPref" system relies
heavily on QString, which means lots of conversions between
the two worlds. Ultimately, I plan to base the preferences
system on std::string and only convert to QString when
pushing through Qt's property system or when writing into
Qt's settings.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-06-13 22:59:32 +02:00 committed by bstoeger
parent 82fc9de40b
commit ccdd92aeb7
78 changed files with 645 additions and 694 deletions

View file

@ -289,7 +289,7 @@ int parse_file(const char *filename, struct divelog *log)
auto [mem, err] = readfile(filename);
if (err < 0) {
/* we don't want to display an error if this was the default file */
if (same_string(filename, prefs.default_filename))
if (filename == prefs.default_filename)
return 0;
return report_error(translate("gettextFromC", "Failed to read '%s'"), filename);