mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

preferences: use std::string in struct preferences

Browse source 
This is a messy commit, because the "qPref" system relies
heavily on QString, which means lots of conversions between
the two worlds. Ultimately, I plan to base the preferences
system on std::string and only convert to QString when
pushing through Qt's property system or when writing into
Qt's settings.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2024-06-13 22:59:32 +02:00 • committed by bstoeger
parent 82fc9de40b
commit ccdd92aeb7
78 changed files with 645 additions and 694 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/testqPrefUpdateManager.cpp
View file

@ -22,7 +22,7 @@ void TestQPrefUpdateManager::test_struct_get()
auto tst = qPrefUpdateManager::instance();
prefs.update_manager.dont_check_for_updates = true;
prefs.update_manager.last_version_used = copy_qstring("last_version");
prefs.update_manager.last_version_used = "last_version";
prefs.update_manager.next_check = QDate::fromString("11/09/1957", "dd/MM/yyyy").toJulianDay();
QCOMPARE(tst->dont_check_for_updates(), true);
@ -42,7 +42,7 @@ void TestQPrefUpdateManager::test_set_struct()
tst->set_uuidString("uuid");
QCOMPARE(prefs.update_manager.dont_check_for_updates, false);
QCOMPARE(QString(prefs.update_manager.last_version_used), QString("last_version2"));
QCOMPARE(QString::fromStdString(prefs.update_manager.last_version_used), QString("last_version2"));
QCOMPARE(QDate::fromJulianDay(prefs.update_manager.next_check), QDate::fromString("11/09/1957", "dd/MM/yyyy"));
QCOMPARE(tst->uuidString(), QString("uuid"));
}
@ -63,12 +63,12 @@ void TestQPrefUpdateManager::test_set_load_struct()
tst->set_uuidString("uuid2");
prefs.update_manager.dont_check_for_updates = true;
prefs.update_manager.last_version_used = copy_qstring("last_version");
prefs.update_manager.last_version_used = "last_version";
prefs.update_manager.next_check = 1000;
tst->load();
QCOMPARE(prefs.update_manager.dont_check_for_updates, false);
QCOMPARE(QString(prefs.update_manager.last_version_used), QString("last_version2"));
QCOMPARE(QString::fromStdString(prefs.update_manager.last_version_used), QString("last_version2"));
QCOMPARE(QDate::fromJulianDay(prefs.update_manager.next_check), QDate::fromString("11/09/1957", "dd/MM/yyyy"));
QCOMPARE(tst->uuidString(), QString("uuid2"));
}
@ -80,12 +80,12 @@ void TestQPrefUpdateManager::test_struct_disk()
auto tst = qPrefUpdateManager::instance();
prefs.update_manager.dont_check_for_updates = true;
prefs.update_manager.last_version_used = copy_qstring("last_version");
prefs.update_manager.last_version_used = "last_version";
prefs.update_manager.next_check = QDate::fromString("11/09/1957", "dd/MM/yyyy").toJulianDay();
tst->sync();
prefs.update_manager.dont_check_for_updates = false;
prefs.update_manager.last_version_used = copy_qstring("");
prefs.update_manager.last_version_used.clear();
prefs.update_manager.next_check = 1000;
tst->load();