mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Desktop: fix crash on dive site tab

Browse source 
An interesting crash:

1) On the dive site tab select a dive site such that only one
   trip is shown.
2) Unselect all dives.
3) Press CTRL-A while the dive list has focus.
4) This will select a trip.
5) In MainTab::updateDiveInfo() this will switch to the previous
   tab active when in trip mode.
6) This will reset the filter.
7) This will reset the currentTrip field which we just set.
8) Since we just set the currentTrip field, we don't expect
   it to change and reference a null pointer.

To fix, don't switch tabs when on the dive site tab. This also
improves user experience as there seems to be no reason to switch
away from the dive site tab.

Currently the index of the dive site tab is hard-coded - this
should be changed!

Fixes #2077

Reported-by: Doug Junkins <junkins@foghead.com>
Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-05-04 14:23:46 +02:00 committed by Dirk Hohndel
parent 9442e17ba8
commit ce140f2925
1 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
desktop-widgets/tab-widgets/maintab.cpp
View file

@ -431,19 +431,25 @@ void MainTab::updateDiveInfo()
widget->updateData(); widget->updateData();
if (current_dive) { if (current_dive) {
// If we're on the dive-site tab, we don't want to switch tab when entering / exiting
// trip mode. The reason is that
// 1) this disrupts the user-experience and
// 2) the filter is reset, potentially erasing the current trip under our feet.
// TODO: Don't hard code tab location!
bool onDiveSiteTab = ui.tabWidget->currentIndex() == 6;
if (MainWindow::instance() && MainWindow::instance()->diveList->selectedTrips().count() == 1) { if (MainWindow::instance() && MainWindow::instance()->diveList->selectedTrips().count() == 1) {
// Remember the tab selected for last dive currentTrip = MainWindow::instance()->diveList->selectedTrips().front();
if (lastSelectedDive) // Remember the tab selected for last dive but only if we're not on the dive site tab
if (lastSelectedDive && !onDiveSiteTab)
lastTabSelectedDive = ui.tabWidget->currentIndex(); lastTabSelectedDive = ui.tabWidget->currentIndex();
ui.tabWidget->setTabText(0, tr("Trip notes")); ui.tabWidget->setTabText(0, tr("Trip notes"));
ui.tabWidget->setTabEnabled(1, false); ui.tabWidget->setTabEnabled(1, false);
ui.tabWidget->setTabEnabled(2, false); ui.tabWidget->setTabEnabled(2, false);
ui.tabWidget->setTabEnabled(5, false); ui.tabWidget->setTabEnabled(5, false);
// Recover the tab selected for last dive trip // Recover the tab selected for last dive trip but only if we're not on the dive site tab
if (lastSelectedDive) if (lastSelectedDive && !onDiveSiteTab)
ui.tabWidget->setCurrentIndex(lastTabSelectedDiveTrip); ui.tabWidget->setCurrentIndex(lastTabSelectedDiveTrip);
lastSelectedDive = false; lastSelectedDive = false;
currentTrip = *MainWindow::instance()->diveList->selectedTrips().begin();
// only use trip relevant fields // only use trip relevant fields
ui.divemaster->setVisible(false); ui.divemaster->setVisible(false);
ui.DivemasterLabel->setVisible(false); ui.DivemasterLabel->setVisible(false);
@ -482,8 +488,8 @@ void MainTab::updateDiveInfo()
ui.duration->setVisible(false); ui.duration->setVisible(false);
ui.durationLabel->setVisible(false); ui.durationLabel->setVisible(false);
} else { } else {
// Remember the tab selected for last dive trip // Remember the tab selected for last dive trip but only if we're not on the dive site tab
if (!lastSelectedDive) if (!lastSelectedDive && !onDiveSiteTab)
lastTabSelectedDiveTrip = ui.tabWidget->currentIndex(); lastTabSelectedDiveTrip = ui.tabWidget->currentIndex();
ui.tabWidget->setTabText(0, tr("Notes")); ui.tabWidget->setTabText(0, tr("Notes"));
ui.tabWidget->setTabEnabled(1, true); ui.tabWidget->setTabEnabled(1, true);
@ -491,8 +497,8 @@ void MainTab::updateDiveInfo()
ui.tabWidget->setTabEnabled(3, true); ui.tabWidget->setTabEnabled(3, true);
ui.tabWidget->setTabEnabled(4, true); ui.tabWidget->setTabEnabled(4, true);
ui.tabWidget->setTabEnabled(5, true); ui.tabWidget->setTabEnabled(5, true);
// Recover the tab selected for last dive // Recover the tab selected for last dive but only if we're not on the dive site tab
if (!lastSelectedDive) if (!lastSelectedDive && !onDiveSiteTab)
ui.tabWidget->setCurrentIndex(lastTabSelectedDive); ui.tabWidget->setCurrentIndex(lastTabSelectedDive);
lastSelectedDive = true; lastSelectedDive = true;
currentTrip = NULL; currentTrip = NULL;