From ce608b7ecf795865906082a5af89d724896d1dea Mon Sep 17 00:00:00 2001 From: Miika Turkia Date: Tue, 8 Sep 2015 20:12:29 +0300 Subject: [PATCH] Fix a crash on divelogs.de export Subsurface crashes when multiple dives are selected on divelogs.de export. The crash occurs on malloc that is called indirectly from xmlReadMemory(). Signed-off-by: Miika Turkia Signed-off-by: Dirk Hohndel --- qt-ui/subsurfacewebservices.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qt-ui/subsurfacewebservices.cpp b/qt-ui/subsurfacewebservices.cpp index 1722da4ce..e2e3b3e78 100644 --- a/qt-ui/subsurfacewebservices.cpp +++ b/qt-ui/subsurfacewebservices.cpp @@ -175,7 +175,6 @@ bool DivelogsDeWebServices::prepare_dives_for_divelogs(const QString &tempfile, /* walk the dive list in chronological order */ int i; struct dive *dive; - struct membuffer mb = { 0 }; for_each_dive (i, dive) { FILE *f; char filename[PATH_MAX]; @@ -183,6 +182,7 @@ bool DivelogsDeWebServices::prepare_dives_for_divelogs(const QString &tempfile, const char *membuf; xmlDoc *transformed; struct zip_source *s; + struct membuffer mb = { 0 }; /* * Get the i'th dive in XML format so we can process it.