From cec1ea182e49a855785b1437123ec85a713a879f Mon Sep 17 00:00:00 2001 From: "Lubomir I. Ivanov" Date: Tue, 5 Aug 2014 20:47:25 +0300 Subject: [PATCH] Print: rename the variable 'isHeading' to 'newHeading' This better describes what the variable (flag) does. It's used to inform the loop that the last row goes our of the page limit and that we need to place a new heading on a new page. In that context 'newHeading' is more meaningful. The name 'isHeading' is confusing for (i == 0), since it remains 'false' yet the 0 index row is actually a heading. Signed-off-by: Lubomir I. Ivanov Signed-off-by: Dirk Hohndel --- qt-ui/printlayout.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qt-ui/printlayout.cpp b/qt-ui/printlayout.cpp index 8fdee858f..f9b71d9b3 100644 --- a/qt-ui/printlayout.cpp +++ b/qt-ui/printlayout.cpp @@ -385,7 +385,7 @@ void PrintLayout::printTable() * two should be enough! */ const int passes[] = { 70, 10 }; int tableHeight = 0, lastAccIndex = 0, rowH, accH, headings, headingRowHeightD2, headingRowHeight; - bool isHeading = false; + bool newHeading = false; for (unsigned int pass = 0; pass < sizeof(passes) / sizeof(passes[0]); pass++) { progress = headings = accH = 0; @@ -399,15 +399,15 @@ void PrintLayout::printTable() if (rowH > pageH - headingRowHeight) // skip huge rows. we don't support row spanning on multiple pages. continue; accH += rowH; - if (isHeading) { + if (newHeading) { headings += rowH; - isHeading = false; + newHeading = false; } if (accH > pageH) { lastAccIndex = i; pageIndexes.append(pageIndexes.last() + (accH - rowH)); addTablePrintHeadingRow(&model, i); - isHeading = true; + newHeading = true; accH = 0; i--; }