core: turn a memblock in the parser to std::string

Browse source

This avoid memory-management troubles. Had to convert a few
of the parsers (cochran, datatrak, liquivision) to C++.
Also had to convert libdivecomputer.c. This was less
painful than expected.

std::string is used because parts of the code assumes
that the data is null terminated after the last character
of the data. std::string does precisely that.

One disadvantage is that std::string clears its memory
when resizing / initializing. Thus we read the file onto
freshly cleared data, which some might thing is a
performance regression. Until someone shows me that this
matters, I don't care.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>

...

This commit is contained in:

Berthold Stoeger 2024-03-01 13:09:20 +01:00 • committed by Michael Keller

parent 2f4dbf1848

commit cf7c54bd56

12 changed files with 233 additions and 285 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1665

core/libdivecomputer.cpp Normal file

View file

File diff suppressed because it is too large Load diff