cleanup: fix SkipEmptyParts warning for mobile

And while doing that, have all the cases where we already include
qthelper.h simply use a define in that header file - but keep the two
other instances of the define where the C++ source don't need qthelper.h
otherwise.

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2021-11-21 17:20:25 -08:00
parent d15ecef706
commit cfd6a1634f
7 changed files with 8 additions and 32 deletions

View file

@ -1218,8 +1218,8 @@ void QMLManager::commitChanges(QString diveId, QString number, QString date, QSt
}
// normalize the tag list we have and the one we get from the UI
// try hard to deal with accidental white space issues
QStringList existingTagList = get_taglist_string(d->tag_list).split(",", QString::SkipEmptyParts);
QStringList newTagList = tags.split(",", QString::SkipEmptyParts);
QStringList existingTagList = get_taglist_string(d->tag_list).split(",", SKIP_EMPTY);
QStringList newTagList = tags.split(",", SKIP_EMPTY);
QStringList newCleanTagList;
for (QString s: newTagList) {
if (!s.simplified().isEmpty())