From d000cb2b0d038264abb1384c037da10d753549b9 Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Thu, 2 Jan 2020 08:30:40 +0100 Subject: [PATCH] mobile-widgetes/qml: standardize QML/C++ interface Do not use a.set_b(value); it works, but it introduces yet another way of using the QML/C++ interface, furthermore the function might not be called set_b in some future, which is the reason the function is define in Q_PROPERTY Use a.b = value, that respects Q_PROPERTY, and is slightly more performant, most importantly it's like all the other settings so noone starts wondering why this is special. Signed-off-by: Jan Iversen Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/Settings.qml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mobile-widgets/qml/Settings.qml b/mobile-widgets/qml/Settings.qml index 100ecb9e5..60aeefd2f 100644 --- a/mobile-widgets/qml/Settings.qml +++ b/mobile-widgets/qml/Settings.qml @@ -461,7 +461,7 @@ Kirigami.ScrollablePage { enabled: PrefUnits.unit_system === "metric" Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefUnits.set_unit_system("imperial") + PrefUnits.unit_system = "imperial" manager.changesNeedSaving() manager.refreshDiveList() } @@ -478,7 +478,7 @@ Kirigami.ScrollablePage { enabled: PrefUnits.unit_system === "imperial" Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefUnits.set_unit_system("metric") + PrefUnits.unit_system = "metric" manager.changesNeedSaving() manager.refreshDiveList() } @@ -516,7 +516,7 @@ Kirigami.ScrollablePage { checked: PrefGeneral.filterFullTextNotes Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefGeneral.set_filterFullTextNotes(checked) + PrefGeneral.filterFullTextNotes = checked } } @@ -532,7 +532,7 @@ Kirigami.ScrollablePage { checked: PrefGeneral.filterCaseSensitive Layout.preferredWidth: gridWidth * 0.25 onClicked: { - PrefGeneral.set_filterCaseSensitive(checked) + PrefGeneral.filterCaseSensitive = checked } }