mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

formatting: move get_trip_title to string-format.h and split it

Browse source 
To enable grouping by trip in the statistics module, split
the get_trip_title() function in a version that appends
a "(n dive(s)" string an one that doesn't. The statistics
module doesn't want that added string, since it displays
the number of dives in a different way.

Also, move the functions to string-format.h, where these
are collected. And rename them to camelCase. Yes, it's
ugly, but consistent with most other C++ code in the code
base.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2021-12-16 23:09:39 +01:00 • committed by Dirk Hohndel
parent 5d1f12438b
commit d1b8f1ca3d
6 changed files with 35 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

4
desktop-widgets/tripselectiondialog.cpp
View file

@ -1,7 +1,7 @@
// SPDX-License-Identifier: GPL-2.0
#include "tripselectiondialog.h"
#include "core/string-format.h"
#include "core/trip.h"
#include "core/qthelper.h"
#include <QShortcut>
#include <QPushButton>
@ -19,7 +19,7 @@ TripSelectionDialog::TripSelectionDialog(QWidget *parent) : QDialog(parent)
QStringList list;
list.reserve(trip_table.nr);
for (int i = 0; i < trip_table.nr; ++i)
list.push_back(get_trip_string(trip_table.trips[i]));
list.push_back(formatTripTitleWithDives(trip_table.trips[i]));
ui.trips->addItems(list);
}