From d1bee58dad50632501f6c43ef9aa6fb257b13854 Mon Sep 17 00:00:00 2001 From: jan Iversen Date: Thu, 19 Dec 2019 10:40:54 +0100 Subject: [PATCH] mobile UI/login: move onCompleted actions to main manager.finishSetup() have nothing to do with startpage/divelist, but belong in main (seeing main as responsible for setup and window layout). Move onCompleted functionality to main. Signed-off-by: Jan Iversen Signed-off-by: Dirk Hohndel --- mobile-widgets/qml/DiveList.qml | 5 ----- mobile-widgets/qml/main.qml | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/mobile-widgets/qml/DiveList.qml b/mobile-widgets/qml/DiveList.qml index f8b1744bd..2dac5aa2a 100644 --- a/mobile-widgets/qml/DiveList.qml +++ b/mobile-widgets/qml/DiveList.qml @@ -408,11 +408,6 @@ Kirigami.ScrollablePage { onVisibleChanged: { setupActions(); } - - Component.onCompleted: { - manager.finishSetup(); - setupActions(); - } } Controls.Label { diff --git a/mobile-widgets/qml/main.qml b/mobile-widgets/qml/main.qml index 728a06d08..7e859936c 100644 --- a/mobile-widgets/qml/main.qml +++ b/mobile-widgets/qml/main.qml @@ -858,8 +858,10 @@ if you have network connectivity and want to sync your data to cloud storage."), rootItem.opacity = 1 manager.appendTextToLog("setting the defaultColumnWidth to " + Kirigami.Units.gridUnit * 21) pageStack.defaultColumnWidth = Kirigami.Units.gridUnit * 21 + manager.finishSetup() manager.appInitialized() } + /* TODO: Verify where opacity went to. Behavior on opacity { NumberAnimation {