mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove pointless assignments

Browse source 
tissue_tolerance wasn't used after it was assigned.
type was overwritten after it was assigned.
serial was overwritten after the last /= 100.
event is assigned in the for loop.
clear isn't used after the assignment

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Dirk Hohndel 2014-03-03 21:24:52 -08:00
parent 99b8e85d73
commit d24d2288f3
5 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
divelist.c
View file

@ -188,7 +188,7 @@ int total_weight(struct dive *dive)
static int active_o2(struct dive *dive, struct divecomputer *dc, duration_t time) static int active_o2(struct dive *dive, struct divecomputer *dc, duration_t time)
{ {
int o2permille = dive->cylinder[0].gasmix.o2.permille; int o2permille = dive->cylinder[0].gasmix.o2.permille;
struct event *event = dc->events; struct event *event;
if (!o2permille) if (!o2permille)
o2permille = O2_IN_AIR; o2permille = O2_IN_AIR;

1
libdivecomputer.c
View file

@ -577,7 +577,6 @@ static unsigned int undo_libdivecomputer_suunto_nr_changes(unsigned int serial)
b2 = serial % 100; b2 = serial % 100;
serial /= 100; serial /= 100;
b3 = serial % 100; b3 = serial % 100;
serial /= 100;
serial = b0 + (b1 << 8) + (b2 << 16) + (b3 << 24); serial = b0 + (b1 << 8) + (b2 << 16) + (b3 << 24);
return serial; return serial;

2
profile.c
View file

@ -1194,7 +1194,7 @@ static void calculate_ndl_tts(double tissue_tolerance, struct plot_data *entry,
if (deco_allowed_depth(tissue_tolerance, surface_pressure, dive, 1) <= next_stop) { if (deco_allowed_depth(tissue_tolerance, surface_pressure, dive, 1) <= next_stop) {
/* move to the next stop and add the travel between stops */ /* move to the next stop and add the travel between stops */
for (; ascent_depth > next_stop; ascent_depth -= ascent_mm_per_deco_step, entry->tts_calc += ascent_s_per_deco_step) for (; ascent_depth > next_stop; ascent_depth -= ascent_mm_per_deco_step, entry->tts_calc += ascent_s_per_deco_step)
tissue_tolerance = add_segment(depth_to_mbar(ascent_depth, dive) / 1000.0, add_segment(depth_to_mbar(ascent_depth, dive) / 1000.0,
&dive->cylinder[cylinderindex].gasmix, ascent_s_per_deco_step, entry->po2 * 1000, dive); &dive->cylinder[cylinderindex].gasmix, ascent_s_per_deco_step, entry->po2 * 1000, dive);
ascent_depth = next_stop; ascent_depth = next_stop;
next_stop -= deco_stepsize; next_stop -= deco_stepsize;

4
qt-ui/globe.cpp
View file

@ -150,10 +150,8 @@ void GlobeGPS::mouseClicked(qreal lon, qreal lat, GeoDataCoordinates::Unit unit)
} }
if (selectedDiveIds.empty()) if (selectedDiveIds.empty())
return; return;
if (clear) { if (clear)
MainWindow::instance()->dive_list()->unselectDives(); MainWindow::instance()->dive_list()->unselectDives();
clear = false;
}
MainWindow::instance()->dive_list()->selectDives(selectedDiveIds); MainWindow::instance()->dive_list()->selectDives(selectedDiveIds);
} }

2
uemis-downloader.c
View file

@ -564,7 +564,7 @@ static void parse_divespot(char *buf)
while (*tag && strcmp(tag, "object_id")); while (*tag && strcmp(tag, "object_id"));
if (!*tag) if (!*tag)
return; return;
type = next_token(&bp); next_token(&bp);
val = next_token(&bp); val = next_token(&bp);
divespot = atoi(val); divespot = atoi(val);
do { do {