From d520ac22864fed77f44de9461c3bb5302b22e30f Mon Sep 17 00:00:00 2001 From: Berthold Stoeger Date: Sun, 12 Apr 2020 12:20:25 +0200 Subject: [PATCH] cleanup: remove parameter to ProfleWidget2::replot() Firstly, the parameter appears conceptually wrong, as replot suggests that the currently shown dive is replot. Secondly, the only caller that passed a parameter was passing in current_dive, which is just what happens if one doesn't pass a parameter. Therefore, change that caller (call plotDive directly) and remove the parameter. Signed-off-by: Berthold Stoeger --- desktop-widgets/mainwindow.cpp | 2 +- profile-widget/profilewidget2.cpp | 4 ++-- profile-widget/profilewidget2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/desktop-widgets/mainwindow.cpp b/desktop-widgets/mainwindow.cpp index cb1179d8c..a0a0dded0 100644 --- a/desktop-widgets/mainwindow.cpp +++ b/desktop-widgets/mainwindow.cpp @@ -783,7 +783,7 @@ void MainWindow::refreshProfile() { showProfile(); configureToolbar(); - graphics->replot(current_dive); + graphics->plotDive(current_dive, true); DivePictureModel::instance()->updateDivePictures(); } diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp index 365f4758d..b516b1544 100644 --- a/profile-widget/profilewidget2.cpp +++ b/profile-widget/profilewidget2.cpp @@ -379,10 +379,10 @@ void ProfileWidget2::setupItemOnScene() gasYAxis->setZValue(timeAxis->zValue() + 1); } -void ProfileWidget2::replot(struct dive *d) +void ProfileWidget2::replot() { dataModel->clear(); - plotDive(d, true, false); + plotDive(nullptr, true, false); } void ProfileWidget2::createPPGas(PartialPressureGasItem *item, int verticalColumn, color_index_t color, color_index_t colorAlert, diff --git a/profile-widget/profilewidget2.h b/profile-widget/profilewidget2.h index e00bda074..6461f83ef 100644 --- a/profile-widget/profilewidget2.h +++ b/profile-widget/profilewidget2.h @@ -108,7 +108,7 @@ slots: // Necessary to call from QAction's signals. void actionRequestedReplot(bool triggered); void setEmptyState(); void setProfileState(); - void replot(dive *d = 0); + void replot(); #ifndef SUBSURFACE_MOBILE void plotPictures(); void removePictures(const QVector &fileUrls);