mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-28 05:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

mobile/divelist: remove showDiveIndex QML-function

Browse source 
The currently shown dive is now controlled by the core.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Berthold Stoeger 2019-12-21 20:17:05 +01:00 committed by Dirk Hohndel
parent c34b7857fc
commit d55ea8f875
3 changed files with 0 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
mobile-widgets/qml/DiveDetails.qml
View file

@ -229,11 +229,6 @@ Kirigami.Page {
} }
} }
function showDiveIndex(id) {
currentIndex = swipeModel.getIdxForId(id);
diveDetailsListView.positionViewAtIndex(currentIndex, ListView.End);
}
function endEditMode() { function endEditMode() {
// if we were adding a dive, we need to remove it // if we were adding a dive, we need to remove it
if (state === "add") if (state === "add")

1
mobile-widgets/qml/DiveDetailsEdit.qml
View file

@ -137,7 +137,6 @@ Item {
diveDetailsListView.currentItem.modelData.visibility = detailsEdit.visibility diveDetailsListView.currentItem.modelData.visibility = detailsEdit.visibility
Qt.inputMethod.hide() Qt.inputMethod.hide()
// now make sure we directly show the saved dive (this may be a new dive, or it may have moved) // now make sure we directly show the saved dive (this may be a new dive, or it may have moved)
showDiveIndex(newIdx)
clearDetailsEdit() clearDetailsEdit()
} }

3
mobile-widgets/qml/DiveList.qml
View file

@ -420,9 +420,6 @@ Kirigami.ScrollablePage {
if (diveListModel) if (diveListModel)
diveListModel.setActiveTrip(diveListView.currentItem.myData.tripId) diveListModel.setActiveTrip(diveListView.currentItem.myData.tripId)
// update the diveDetails page to also show that dive
detailsWindow.showDiveIndex(idx)
// updating the index of the ListView triggers a non-linear scroll // updating the index of the ListView triggers a non-linear scroll
// animation that can be very slow. the fix is to stop this animation // animation that can be very slow. the fix is to stop this animation
// by setting contentY to itself and then using positionViewAtIndex(). // by setting contentY to itself and then using positionViewAtIndex().