mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Slight refactor of DAN parse code

Browse source 
Mostly NFC; this commit is mainly to get familiar with the codebase and to meet
the people who will review these changes.

I hope to make some changes to the DAN parsing code to eventually extract more
metainfo from my aqualung divecomputer's `.zxu` formatted logs. To do so, and
for me to be able to work on this efficiently, I've refactored the DAN parsing
code using a bit more modern C++-style, as well as being more true-to-spec wrt.
the (...ancient) DAN file format documentation that i could dig up... hopefully
that's an alright tradeoff for the project.

This more true-to-spec parsing also fixed a bug with the number being parsed
from the incorrect index in the ZDH vector (or, atleast i consider it a bug -
the "Export sequence" number was being used as the dive number, instead of the
"Internal Dive Sequence" number. The latter, described in the spec as: `The
sequence number assigned to the dive by the recording computer`).

Also contains some unrelated formatting changes; i tried to keep these minimal
(i presume these files haven't been touched in a while by `clang-format`).

Signed-off-by: Morten Borup Petersen <morten_bp@live.dk>
This commit is contained in:
Morten Borup Petersen 2024-11-02 18:23:59 +01:00 • committed by Michael Keller
parent e2b0851ddc
commit d59eb9bdfa
5 changed files with 238 additions and 137 deletions
Download patch file Download diff file Expand all files Collapse all files

6
dives/DL7.zxu
View file

@ -9,6 +9,6 @@ ZDP{
|3300|10|||||
|3600|0|||||
ZDP}
ZDT|2|2|10.0|20180102110000|25||
ZDH|3|3|I|QS|20180103101000|28|11|FO2|||
ZDT|3|3|10.0|20180103102000|26||
ZDT|1|2|10.0|20180102110000|25||
ZDH|1|3|I|QS|20180103101000|28|11|FO2|||
ZDT|1|3|10.0|20180103102000|26||