mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Code Cleanup, less magic indexes.

Browse source 
This patch removes the magic indexes used to control the mainwindow
display of the profile and planner by an enum. a bit more verbose
but hard to miss.

Signed-off-by: Tomaz Canabrava <tcanabrava@kde.org>
This commit is contained in:
Tomaz Canabrava 2013-09-26 11:14:40 -03:00
parent fd7a671a1d
commit d6f2988bcf
2 changed files with 9 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
qt-ui/mainwindow.cpp
View file

@ -215,15 +215,15 @@ void MainWindow::on_actionDivePlanner_triggered()
{ {
disableDcShortcuts(); disableDcShortcuts();
DivePlannerPointsModel::instance()->setPlanMode(true); DivePlannerPointsModel::instance()->setPlanMode(true);
ui->stackedWidget->setCurrentIndex(1); ui->stackedWidget->setCurrentIndex(PLANNERPROFILE);
ui->infoPane->setCurrentIndex(1); ui->infoPane->setCurrentIndex(PLANNERWIDGET);
} }
void MainWindow::showProfile() void MainWindow::showProfile()
{ {
enableDcShortcuts(); enableDcShortcuts();
ui->stackedWidget->setCurrentIndex(0); ui->stackedWidget->setCurrentIndex(PROFILE);
ui->infoPane->setCurrentIndex(0); ui->infoPane->setCurrentIndex(MAINTAB);
} }
@ -271,12 +271,12 @@ void MainWindow::on_actionAddDive_triggered()
// now cheat - create one dive that we use to store the info tab data in // now cheat - create one dive that we use to store the info tab data in
struct dive *dive = alloc_dive(); struct dive *dive = alloc_dive();
dive->when = QDateTime::currentMSecsSinceEpoch() / 1000L; dive->when = QDateTime::currentMSecsSinceEpoch() / 1000L;
dive->dc.model = _("manually added dive"); dive->dc.model = _("manually added dive"); // do not use tr here since it expects a char*.
record_dive(dive); record_dive(dive);
select_dive(get_divenr(dive)); select_dive(get_divenr(dive));
ui->InfoWidget->updateDiveInfo(selected_dive); ui->InfoWidget->updateDiveInfo(selected_dive);
ui->stackedWidget->setCurrentIndex(1); ui->stackedWidget->setCurrentIndex(PLANNERPROFILE); // Planner.
ui->infoPane->setCurrentIndex(0); ui->infoPane->setCurrentIndex(MAINTAB);
DivePlannerPointsModel::instance()->createSimpleDive(); DivePlannerPointsModel::instance()->createSimpleDive();
refreshDisplay(); refreshDisplay();
ui->InfoWidget->addDiveStarted(); ui->InfoWidget->addDiveStarted();

2
qt-ui/mainwindow.h
View file

@ -37,6 +37,8 @@ class MainWindow : public QMainWindow
Q_OBJECT Q_OBJECT
public: public:
enum {COLLAPSED, EXPANDED}; enum {COLLAPSED, EXPANDED};
enum StackWidgetIndexes{ PROFILE, PLANNERPROFILE};
enum InfoWidgetIndexes{ MAINTAB, PLANNERWIDGET};
MainWindow(); MainWindow();
ProfileGraphicsView *graphics(); ProfileGraphicsView *graphics();