mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Do not create a backup for Q_FOREACH container

Browse source 
Q_FOREACH will expand and already creates a copy of the
contained container, so this is just a waste of cpu cycles
and also increases a tiny bit the memory consumption.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2014-07-15 14:43:20 -03:00 • committed by Dirk Hohndel
parent eaacac3217
commit d993684fec
6 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
qt-ui/divepicturewidget.cpp
View file

@ -52,8 +52,7 @@ void DivePictureModel::updateDivePictures()
pictures.push_back(QString(picture->filename));
}
SPixmapList retList = QtConcurrent::blockingMapped<SPixmapList>(pictures, scaleImages);
Q_FOREACH (const SPixmap &pixmap, retList)
Q_FOREACH (const SPixmap &pixmap, QtConcurrent::blockingMapped<SPixmapList>(pictures, scaleImages))
stringPixmapCache[pixmap.first].image = pixmap.second;
beginInsertRows(QModelIndex(), 0, numberOfPictures - 1);