mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix leak(s) in core/git-access.c

Browse source 
The libgit2 functions git_cred_ssh_key_new() and git_cred_userpass_plaintext_new()
copy their arguments. Therefore, free the string arguments or don't
copy them in the first place.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2018-01-12 18:54:27 +01:00 • committed by Lubomir I. Ivanov
parent de49f2484f
commit daede13571
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
core/git-access.c
View file

@ -204,10 +204,12 @@ int credential_ssh_cb(git_cred **out,
return GIT_EUSER;
}
const char *priv_key = format_string("%s/%s", system_default_directory(), "ssrf_remote.key");
const char *passphrase = prefs.cloud_storage_password ? strdup(prefs.cloud_storage_password) : strdup("");
char *priv_key = format_string("%s/%s", system_default_directory(), "ssrf_remote.key");
const char *passphrase = prefs.cloud_storage_password ? prefs.cloud_storage_password : "";
return git_cred_ssh_key_new(out, username_from_url, NULL, priv_key, passphrase);
int res = git_cred_ssh_key_new(out, username_from_url, NULL, priv_key, passphrase);
free(priv_key);
return res;
}
int credential_https_cb(git_cred **out,
@ -228,7 +230,7 @@ int credential_https_cb(git_cred **out,
}
const char *username = prefs.cloud_storage_email_encoded;
const char *password = prefs.cloud_storage_password ? strdup(prefs.cloud_storage_password) : strdup("");
const char *password = prefs.cloud_storage_password ? prefs.cloud_storage_password : "";
return git_cred_userpass_plaintext_new(out, username, password);
}