mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix memory leak

Browse source 
The QPainter and the QPixmap were being created but never freed. A QPixmap
and a QPainter don't need to be created by new, they can be safely created
on the stack.

So, create them on the stack, pass them via const-reference
and use them correctly.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2015-01-14 13:02:18 -02:00 • committed by Dirk Hohndel
parent 633dd64d2f
commit db4ffd0b70
2 changed files with 19 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
qt-ui/profile/divetooltipitem.h
View file

@ -34,7 +34,7 @@ public:
void collapse();
void expand();
void clear();
void addToolTip(const QString &toolTip, const QIcon &icon = QIcon(), const QPixmap *pixmap = NULL);
void addToolTip(const QString &toolTip, const QIcon &icon = QIcon(), const QPixmap &pixmap = QPixmap());
void refresh(const QPointF &pos);
bool isExpanded() const;
void persistPos();