mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
cleanup: remove QPointer instances
QPointer is a strange "smart" pointer class, which resets itself when the pointed-to QObject is deleted. It does this by listening to the corresponding signal and therefore is surprisingly heavy for a plain pointer. A cynic would say that the existence of QPointer is an expression of Qt's broken ownership model. In any case, QPointer was only used at two places, were it was 100% useless: As a parameter to a function and as a locally scoped pointer. It only makes sense if a) there is a chance that the object disappears during the pointer's lifetime and b) it is actually checked for null before use None of which was the case here. Remove. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
parent
fa6eb6144b
commit
dc37ba7758
3 changed files with 3 additions and 4 deletions
|
|
@ -32,7 +32,7 @@ private:
|
|||
void render(int Pages);
|
||||
void flowRender();
|
||||
void putProfileImage(const QRect &box, const QRect &viewPort, QPainter *painter,
|
||||
struct dive *dive, QPointer<ProfileWidget2> profile);
|
||||
struct dive *dive, ProfileWidget2 *profile);
|
||||
|
||||
private slots:
|
||||
void templateProgessUpdated(int value);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue