mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

OSTC3 incorrect notice to upgrade firmware

Browse source 
See https://github.com/Subsurface-divelog/subsurface/issues/342. The reason is
that we never get a DC_EVENT_DEVINFO when doing a memory dump. Just do not
offer to update firmware when we are creating a libdc dump.

Full credits of this fix go to Anton.

Fixed-by: Anton Lundin <glance@acc.umu.se>
Signed-off-by: Jan Mulder <jlmulder@xs4all.nl>
This commit is contained in:
Jan Mulder 2017-04-24 18:29:33 +02:00 • committed by Dirk Hohndel
parent cd9dc8f8fc
commit dc9cf7bcbc
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
desktop-widgets/downloadfromdivecomputer.cpp
View file

@ -385,9 +385,11 @@ void DownloadFromDCWidget::on_downloadCancelRetryButton_clicked()
// You can enter "OSTC 3" and download just fine from a "OSTC Sport", but
// this check will compair apples and oranges, firmware wise, then.
QString product(ui.product->currentText());
if (product == "OSTC 3" || product == "OSTC 3+" ||
//
// We shouldn't do this for memory dumps.
if ((product == "OSTC 3" || product == "OSTC 3+" ||
product == "OSTC Cr" || product == "OSTC Sport" ||
product == "OSTC 4")
product == "OSTC 4") && !data.libdc_dump)
ostcFirmwareCheck = new OstcFirmwareCheck(product);
}