mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

maplocationmodel: use QVector for the MapLocation storage

Browse source 
QVector is faster, use it for "m_mapLocations" instead of QList.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
This commit is contained in:
Lubomir I. Ivanov 2017-07-17 23:04:00 +03:00 • committed by Dirk Hohndel
parent ffcfde3b62
commit de90480b46
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
mobile-widgets/qmlmapwidgethelper.cpp
View file

@ -29,7 +29,7 @@ void MapWidgetHelper::reloadMapLocations()
struct dive_site *ds; struct dive_site *ds;
int idx; int idx;
m_mapLocationModel->clear(); m_mapLocationModel->clear();
QList<MapLocation *> locationList; QVector<MapLocation *> locationList;
for_each_dive_site(idx, ds) { for_each_dive_site(idx, ds) {
if (!dive_site_has_gps_location(ds)) if (!dive_site_has_gps_location(ds))

2
qt-models/maplocationmodel.cpp
View file

@ -68,7 +68,7 @@ void MapLocationModel::add(MapLocation *location)
endInsertRows(); endInsertRows();
} }
void MapLocationModel::addList(QList<MapLocation *> list) void MapLocationModel::addList(QVector<MapLocation *> list)
{ {
if (!list.size()) if (!list.size())
return; return;

6
qt-models/maplocationmodel.h
View file

@ -3,7 +3,7 @@
#define MAPLOCATIONMODEL_H #define MAPLOCATIONMODEL_H
#include <QObject> #include <QObject>
#include <QList> #include <QVector>
#include <QHash> #include <QHash>
#include <QByteArray> #include <QByteArray>
#include <QAbstractListModel> #include <QAbstractListModel>
@ -43,14 +43,14 @@ public:
int rowCount(const QModelIndex &parent) const override; int rowCount(const QModelIndex &parent) const override;
int count(); int count();
void add(MapLocation *); void add(MapLocation *);
void addList(QList<MapLocation *>); void addList(QVector<MapLocation *>);
void clear(); void clear();
protected: protected:
QHash<int, QByteArray> roleNames() const; QHash<int, QByteArray> roleNames() const;
private: private:
QList<MapLocation *> m_mapLocations; QVector<MapLocation *> m_mapLocations;
QHash<int, QByteArray> m_roles; QHash<int, QByteArray> m_roles;
signals: signals: