mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: pass const-reference to RulerItem2::setPlotInfo()

Browse source 
Instead of passing a pointer, pass a cons reference. This is more
idiomatic and consistent with RulerNodeItem2::setPlotInfo().

Also make the reference passed to RulerNodeItem2::setPlotInfo()
const, to make clear that the argument is copied.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-03-19 20:05:39 +01:00 committed by Dirk Hohndel
parent dc254716cf
commit e19b71709d
3 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
profile-widget/profilewidget2.cpp
View file

@ -718,7 +718,7 @@ void ProfileWidget2::plotDive(const struct dive *d, bool force, bool doClearPict
cylinderPressureAxis->setMinimum(plotInfo.minpressure);
cylinderPressureAxis->setMaximum(plotInfo.maxpressure);
#ifndef SUBSURFACE_MOBILE
rulerItem->setPlotInfo(&plotInfo);
rulerItem->setPlotInfo(plotInfo);
#endif
#ifdef SUBSURFACE_MOBILE

10
profile-widget/ruleritem.cpp
View file

@ -26,7 +26,7 @@ RulerNodeItem2::RulerNodeItem2() :
setFlag(ItemIgnoresTransformations);
}
void RulerNodeItem2::setPlotInfo(plot_info &info)
void RulerNodeItem2::setPlotInfo(const plot_info &info)
{
pInfo = info;
entry = pInfo.entry;
@ -152,11 +152,11 @@ RulerNodeItem2 *RulerItem2::destNode() const
return dest;
}
void RulerItem2::setPlotInfo(plot_info *info)
void RulerItem2::setPlotInfo(const plot_info &info)
{
pInfo = *info;
dest->setPlotInfo(*info);
source->setPlotInfo(*info);
pInfo = info;
dest->setPlotInfo(info);
source->setPlotInfo(info);
dest->recalculate();
source->recalculate();
recalculate();

4
profile-widget/ruleritem.h
View file

@ -18,7 +18,7 @@ class RulerNodeItem2 : public QObject, public QGraphicsEllipseItem {
public:
explicit RulerNodeItem2();
void setRuler(RulerItem2 *r);
void setPlotInfo(struct plot_info &info);
void setPlotInfo(const struct plot_info &info);
void recalculate();
protected:
@ -37,7 +37,7 @@ public:
explicit RulerItem2();
void recalculate();
void setPlotInfo(struct plot_info *pInfo);
void setPlotInfo(const struct plot_info &pInfo);
RulerNodeItem2 *sourceNode() const;
RulerNodeItem2 *destNode() const;
void setAxis(DiveCartesianAxis *time, DiveCartesianAxis *depth);