mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fixed a memory leak related to the satelite icon

Browse source 
divelist.c:get_gps_icon_for_dive()
In all callers of the function use gdk_pixbuf_unref() to
release the returned GdkPixbuf (but also check for NULL).

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lubomir I. Ivanov 2013-02-09 21:29:59 +02:00 • committed by Dirk Hohndel
parent 363c38f557
commit ea21126f62
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
divelist.c
View file

@ -921,6 +921,8 @@ static void fill_one_dive(struct dive *dive,
DIVE_SUIT, suit, DIVE_SUIT, suit,
-1); -1);
if (icon)
gdk_pixbuf_unref(icon);
free(location); free(location);
free(cylinder); free(cylinder);
free(suit); free(suit);
@ -1325,6 +1327,8 @@ static void fill_dive_list(void)
DIVE_TEMPERATURE, dive->watertemp.mkelvin, DIVE_TEMPERATURE, dive->watertemp.mkelvin,
DIVE_SAC, 0, DIVE_SAC, 0,
-1); -1);
if (icon)
gdk_pixbuf_unref(icon);
gtk_tree_store_append(liststore, &iter, NULL); gtk_tree_store_append(liststore, &iter, NULL);
gtk_tree_store_set(liststore, &iter, gtk_tree_store_set(liststore, &iter,
DIVE_INDEX, i, DIVE_INDEX, i,