mirror of
https://github.com/subsurface/subsurface.git
synced 2025-02-19 22:16:15 +00:00
Dive list: implement proper Qt-model semantics for DiveTripModel
Previously, each dive-list modifying function would lead to a full model reset. Instead, implement proper Qt-model semantics using beginInsertRows()/endInsertRows(), beginRemoveRows()/ endRemoveRows(), dataChange(). To do so, a DiveListNotifer singleton is generatated, which broadcasts all changes to the dive-list. Signals are sent by the commands and received by the DiveTripModel. Signals are batched by dive-trip. This seems to be an adequate compromise for the two kinds of list-views (tree and list). In the common usecase mostly dives of a single trip are affected. Thus, batching of dives is performed in two positions: - At command-level to batch by trip - In DiveTripModel to feed batches of contiguous elements to Qt's begin*/end*-functions. This is conceptually simple, but rather complex code. To avoid repetition of complex loops, the batching is implemented in templated-functions, which are passed lambda-functions, which are called for each batch. Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
parent
6ac4ddbeed
commit
ec7d85835f
11 changed files with 645 additions and 100 deletions
|
|
@ -36,6 +36,8 @@
|
|||
#include "core/settings/qPrefPartialPressureGas.h"
|
||||
#include "core/settings/qPrefTechnicalDetails.h"
|
||||
|
||||
#include "core/subsurface-qt/DiveListNotifier.h"
|
||||
|
||||
#include "desktop-widgets/about.h"
|
||||
#include "desktop-widgets/command.h"
|
||||
#include "desktop-widgets/divecomputermanagementdialog.h"
|
||||
|
|
@ -492,8 +494,6 @@ void MainWindow::refreshDisplay(bool doRecreateDiveList)
|
|||
dive_list()->setFocus();
|
||||
WSInfoModel::instance()->updateInfo();
|
||||
ui.actionAutoGroup->setChecked(autogroup);
|
||||
if (amount_selected == 0)
|
||||
cleanUpEmpty();
|
||||
}
|
||||
|
||||
void MainWindow::recreateDiveList()
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue