mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2024-11-30 22:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove check option to show units in text label

Browse source 
Currently the feature to show temperature units while adding dive is
provided through checkbox in preferences->units section. This patch
disables this checkbox and always enables this feature.

Signed-off-by: Lakshman Anumolu <acrlakshman@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lakshman 2014-04-05 11:03:45 -05:00 committed by Dirk Hohndel
parent d6af09b269
commit ecc8c1d995
6 changed files with 5 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pref.h
View file

@ -41,7 +41,6 @@ struct preferences {
bool display_unused_tanks;
bool show_average_depth;
bool zoomed_plot;
bool text_label_with_units;
};
enum unit_system_values {
METRIC,

6
qt-ui/maintab.cpp
View file

@ -202,7 +202,7 @@ void MainTab::hideMessage()
ui.diveEquipmentMessage->animatedHide();
ui.diveInfoMessage->animatedHide();
ui.diveStatisticsMessage->animatedHide();
updateTextLabels();
updateTextLabels(false);
}
void MainTab::closeMessage()
@ -224,12 +224,12 @@ void MainTab::displayMessage(QString str)
ui.diveInfoMessage->animatedShow();
ui.diveStatisticsMessage->setText(str);
ui.diveStatisticsMessage->animatedShow();
updateTextLabels(true);
updateTextLabels();
}
void MainTab::updateTextLabels(bool showUnits)
{
if (showUnits && prefs.text_label_with_units) {
if (showUnits) {
ui.airTempLabel->setText(tr("Air temp [%1]").arg(get_temp_unit()));
ui.waterTempLabel->setText(tr("Water temp [%1]").arg(get_temp_unit()));
} else {

2
qt-ui/maintab.h
View file

@ -94,7 +94,7 @@ slots:
void displayMessage(QString str);
void enableEdition(EditMode newEditMode = NONE);
void toggleTriggeredColumn();
void updateTextLabels(bool showUnits = false);
void updateTextLabels(bool showUnits = true);
private:
Ui::MainTab ui;

3
qt-ui/preferences.cpp
View file

@ -75,7 +75,6 @@ void PreferencesDialog::setUiFromPrefs()
ui.cuft->setChecked(prefs.units.volume == units::CUFT);
ui.kg->setChecked(prefs.units.weight == units::KG);
ui.lbs->setChecked(prefs.units.weight == units::LBS);
ui.text_label_with_units->setChecked(prefs.text_label_with_units);
ui.font->setCurrentFont(QString(prefs.divelist_font));
ui.fontsize->setValue(prefs.font_size);
@ -198,7 +197,6 @@ void PreferencesDialog::syncSettings()
s.setValue("volume", ui.cuft->isChecked() ? units::CUFT : units::LITER);
s.setValue("weight", ui.lbs->isChecked() ? units::LBS : units::KG);
s.setValue("vertical_speed_time", ui.vertical_speed_minutes->isChecked() ? units::MINUTES : units::SECONDS);
SB("text_label_with_units", ui.text_label_with_units);
s.endGroup();
// Defaults
s.beginGroup("GeneralSettings");
@ -255,7 +253,6 @@ void PreferencesDialog::loadSettings()
GET_UNIT("weight", weight, units::LBS, units::KG);
}
GET_UNIT("vertical_speed_time", vertical_speed_time, units::MINUTES, units::SECONDS);
GET_BOOL("text_label_with_units", text_label_with_units);
s.endGroup();
s.beginGroup("TecDetails");
GET_BOOL("po2graph", pp_graphs.po2);

14
qt-ui/preferences.ui
View file

@ -512,20 +512,6 @@
</item>
</layout>
</item>
<item>
<layout class="QHBoxLayout" name="text_label_with_units_hbox">
<item>
<widget class="QCheckBox" name="text_label_with_units">
<property name="enabled">
<bool>true</bool>
</property>
<property name="text">
<string>Show units in text labels</string>
</property>
</widget>
</item>
</layout>
</item>
<item>
<spacer name="verticalSpacer">
<property name="orientation">

3
subsurfacestartup.c
View file

@ -30,8 +30,7 @@ struct preferences default_prefs = {
.display_invalid_dives = false,
.show_sac = false,
.display_unused_tanks = false,
.show_average_depth = true,
.text_label_with_units = false
.show_average_depth = true
};
struct units *get_units()