mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Cleanup: simplify YearInfo class

Browse source 
YearInfo is a trivial wrapper around "stats_t *". All the
constructor / destructor rigmarole seems completely unnecessary.
Remove it. Probably the whole class could be removed, but for
that I'd need more insight into Grantlee, which is low on my
list of priorities for now.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2019-04-26 18:16:02 +02:00 • committed by Dirk Hohndel
parent 8165abf2e7
commit ef76905590
2 changed files with 2 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
desktop-widgets/templatelayout.cpp
View file

@ -210,7 +210,7 @@ QString TemplateLayout::generateStatistics()
stats_summary_auto_free stats;
calculate_stats_summary(&stats, false);
while (stats.stats_yearly != NULL && stats.stats_yearly[i].period) {
YearInfo year(stats.stats_yearly[i]);
YearInfo year{ &stats.stats_yearly[i] };
years.append(QVariant::fromValue(year));
i++;
}
@ -256,13 +256,3 @@ void TemplateLayout::writeTemplate(QString template_name, QString grantlee_templ
qfile.close();
}
}
YearInfo::YearInfo()
{
year = nullptr;
}
YearInfo::~YearInfo()
{
}

10
desktop-widgets/templatelayout.h
View file

@ -34,16 +34,8 @@ signals:
void progressUpdated(int value);
};
class YearInfo {
public:
struct YearInfo {
stats_t *year;
YearInfo(stats_t& year)
:year(&year)
{
}
YearInfo();
~YearInfo();
};
Q_DECLARE_METATYPE(template_options)