mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Mark a lot of TODO's where I think it should be moved to C code.

Browse source 
This marks a lot of todo's where I think there's core stuff being mangled
on the interface - we should remove this from the interface to make
testing and maintenability easier.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Tomaz Canabrava 2014-04-16 23:56:42 -03:00 • committed by Dirk Hohndel
parent 1a1cbc296b
commit f14c14c383
8 changed files with 44 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
qt-ui/diveplanner.cpp
View file

@ -469,6 +469,7 @@ void DivePlannerGraphics::drawProfile()
plannerModel->deleteTemporaryPlan();
return;
}
//TODO: divedatapoint_list_get_max_depth on C - code?
while (dp->next) {
if (dp->time && dp->depth > max_depth)
max_depth = dp->depth;
@ -1489,7 +1490,7 @@ void DivePlannerPointsModel::createTemporaryPlan()
// We just start with a surface node at time = 0
if (!stagingDive)
return;
//TODO: this thingy looks like it could be a good C-based function
diveplan.dp = NULL;
int lastIndex = -1;
for (int i = 0; i < rowCount(); i++) {
@ -1559,6 +1560,7 @@ void DivePlannerPointsModel::createPlan()
return cancelPlan();
createTemporaryPlan();
//TODO: C-based function here?
plan(&diveplan, &cache, &tempDive, isPlanner());
copy_cylinders(stagingDive, tempDive);
int mean[MAX_CYLINDERS], duration[MAX_CYLINDERS];