mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-02-19 22:16:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

Profile: prevent a bug when switching views

Browse source 
While in zoomed mode and when resizing the splitters or
switching views the profile tooltip can end up being at the
wrong location and also the zoom state becomes corrupt,
so perhaps the entire transformation needs to be reset.
To prevent the bug we listen for relevent to the profile
splitter resize event, view changes and clear()/plot() the
entire profile graphics.

This is an slow/expensive solution and perhaps there are
cheaper alternatives e.g. updating only the scene rectangle
and tooltip, somehow.

Signed-off-by: Lubomir I. Ivanov <neolit123@gmail.com>
Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
This commit is contained in:
Lubomir I. Ivanov 2013-07-05 15:33:51 +03:00 • committed by Dirk Hohndel
parent 2e26de5ae6
commit f3b81ab54d
3 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
qt-ui/mainwindow.cpp
View file

@ -81,7 +81,7 @@ void MainWindow::current_dive_changed(int divenr)
void MainWindow::redrawProfile()
{
ui->ProfileWidget->plot(get_dive(selected_dive));
ui->ProfileWidget->refresh();
}
void MainWindow::on_actionNew_triggered()
@ -316,10 +316,16 @@ void MainWindow::on_actionYearlyStatistics_triggered()
view->show();
}
void MainWindow::on_mainSplitter_splitterMoved(int pos, int idx)
{
redrawProfile();
}
void MainWindow::on_infoProfileSplitter_splitterMoved(int pos, int idx)
{
/* always update the floating plus sign icons in the equipment tab */
ui->InfoWidget->equipmentPlusUpdate();
redrawProfile();
}
/**
@ -345,6 +351,7 @@ void MainWindow::on_actionViewProfile_triggered()
{
ui->infoProfileSplitter->setSizes(BEHAVIOR << COLLAPSED << EXPANDED);
ui->mainSplitter->setSizes( BEHAVIOR << EXPANDED << COLLAPSED);
redrawProfile();
}
void MainWindow::on_actionViewInfo_triggered()
@ -370,6 +377,7 @@ void MainWindow::on_actionViewAll_triggered()
// half and half?
ui->mainSplitter->setSizes( QList<int>() << 1 << 1);
redrawProfile();
}
void MainWindow::on_actionPreviousDC_triggered()

1
qt-ui/mainwindow.h
View file

@ -92,6 +92,7 @@ private slots:
void on_actionDivePlanner_triggered();
/* monitor resize of the info-profile splitter */
void on_mainSplitter_splitterMoved(int pos, int idx);
void on_infoProfileSplitter_splitterMoved(int pos, int idx);
void current_dive_changed(int divenr);

1
qt-ui/profilegraphics.cpp
View file

@ -185,6 +185,7 @@ void ProfileGraphicsView::clear()
void ProfileGraphicsView::refresh()
{
clear();
plot(current_dive, TRUE);
}