From f4a2ce101729ff9178c90adbaf6777e3b2cafa7b Mon Sep 17 00:00:00 2001 From: Dirk Hohndel Date: Sat, 25 Jan 2014 07:25:03 -0800 Subject: [PATCH] Fix potential crash at startup Strangely enough, on the system I build this, I don't see the crash. But when I create a DMG and run it on a different Mac, it crashes if updateTicks() is called but scene() still returns 0. Signed-off-by: Dirk Hohndel --- qt-ui/profile/divecartesianaxis.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qt-ui/profile/divecartesianaxis.cpp b/qt-ui/profile/divecartesianaxis.cpp index 8a1b1890d..feeaf12b8 100644 --- a/qt-ui/profile/divecartesianaxis.cpp +++ b/qt-ui/profile/divecartesianaxis.cpp @@ -56,6 +56,8 @@ QColor DiveCartesianAxis::colorForValue(double value) void DiveCartesianAxis::updateTicks() { + if (!scene()) + return; QLineF m = line(); // unused so far: // QGraphicsView *view = scene()->views().first(); @@ -124,7 +126,6 @@ void DiveCartesianAxis::updateTicks() } labels.push_back(label); if (orientation == RightToLeft || orientation == LeftToRight) { - if(showText){ label->setAlignment(Qt::AlignBottom | Qt::AlignHCenter); label->setPos(scene()->sceneRect().width() + 10, m.y1() + tickSize); // position it outside of the scene);