mifr/subsurface
1
0
Fork 0
mirror of https://github.com/subsurface/subsurface.git synced 2025-01-31 23:03:23 +00:00
Code Issues Projects Releases Packages Wiki Activity

desktop: remove scrollto default parameter of DiveListView::selectDive()

Browse source 
No caller was using that parameter.

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
This commit is contained in:
Berthold Stoeger 2020-04-25 15:24:11 +02:00 • committed by Dirk Hohndel
parent e26ac9e58d
commit f8d3501c22
2 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
desktop-widgets/divelistview.cpp
View file

@ -306,7 +306,7 @@ QList<dive_trip_t *> DiveListView::selectedTrips()
return ret; return ret;
} }
void DiveListView::selectDive(QModelIndex idx, bool scrollto) void DiveListView::selectDive(QModelIndex idx)
{ {
if (!idx.isValid()) if (!idx.isValid())
return; return;
@ -314,16 +314,12 @@ void DiveListView::selectDive(QModelIndex idx, bool scrollto)
if (idx.parent().isValid()) { if (idx.parent().isValid()) {
setAnimated(false); setAnimated(false);
expand(idx.parent()); expand(idx.parent());
if (scrollto)
scrollTo(idx.parent());
setAnimated(true); setAnimated(true);
} }
if (scrollto)
scrollTo(idx, PositionAtCenter);
selectionChangeDone(); selectionChangeDone();
} }
void DiveListView::selectDive(int i, bool scrollto) void DiveListView::selectDive(int i)
{ {
if (i == -1) if (i == -1)
return; return;
@ -332,7 +328,7 @@ void DiveListView::selectDive(int i, bool scrollto)
if (match.isEmpty()) if (match.isEmpty())
return; return;
QModelIndex idx = match.first(); QModelIndex idx = match.first();
selectDive(idx, scrollto); selectDive(idx);
} }
void DiveListView::selectDives(const QList<int> &newDiveSelection) void DiveListView::selectDives(const QList<int> &newDiveSelection)

4
desktop-widgets/divelistview.h
View file

@ -86,8 +86,8 @@ private:
void addToTrip(int delta); void addToTrip(int delta);
void matchImagesToDives(QStringList fileNames); void matchImagesToDives(QStringList fileNames);
void loadImageFromURL(QUrl url); void loadImageFromURL(QUrl url);
void selectDive(QModelIndex index, bool scrollto = false); void selectDive(QModelIndex index);
void selectDive(int dive_table_idx, bool scrollto = false); void selectDive(int dive_table_idx);
QNetworkAccessManager manager; QNetworkAccessManager manager;
}; };